Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ImGui spam of ShowCursor/HideCursor #1005

Merged
merged 1 commit into from
Mar 1, 2025
Merged

Fix ImGui spam of ShowCursor/HideCursor #1005

merged 1 commit into from
Mar 1, 2025

Conversation

WSSDude
Copy link
Collaborator

@WSSDude WSSDude commented Mar 1, 2025 •
edited
Loading

Also makes sure that we actually have 200 descriptors for texture, we allocated only 3 (ImGui really needs only 1 though per viewport, we have one in main) but allowed up to 200.

@WSSDude WSSDude marked this pull request as ready for review March 1, 2025 08:10
@WSSDude WSSDude requested a review from maximegmd March 1, 2025 08:10
@WSSDude
Copy link
Collaborator Author

WSSDude commented Mar 1, 2025 •
edited
Loading

Setting ImGuiConfigFlags_NoMouseCursorChange prevents ImGui from setting cursor each frame in Win32 backend, which was the primary cause for the Show/HideCursor not working before after single call. And with the latest addition of ForceCursor game function, this is not needed anymore and is overall cleaner as the game cannot randomly hide our cursor and it ensures proper clipping rect for it.

@maximegmd maximegmd merged commit 12873ce into master Mar 1, 2025
2 checks passed
@WSSDude WSSDude deleted the feature/fix-cursor branch March 1, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximegmd maximegmd maximegmd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WSSDude @maximegmd